Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Separate ESLint settings for ui, content, and background #186

Open
tombeckenham opened this issue Nov 20, 2024 · 0 comments
Open

[BUG] Separate ESLint settings for ui, content, and background #186

tombeckenham opened this issue Nov 20, 2024 · 0 comments
Assignees

Comments

@tombeckenham
Copy link
Collaborator

Describe the Bug

The same ESlint settings have been used across all three areas of the extension. This allows code to be mixed that shouldn't, applies some rules to the background that shouldn't (like hooks), and prevents usage of window on ui.

Expected experience

ESlint should prevent the ui from directly including code from background services, and vice versa. Rules of hooks should only apply to the popup. Globals should be allowed in the popup

Steps To Reproduce

  1. Include a file from backround in the UI - eslint doesn't complain and it should
  2. Try creating a function starting with "use" in the backgrond - eslint complains when it shouldn't
  3. Try using the window global in the popup - eslint complains when it shouldn't

Environment

- OS: Mac
- Node:
- npm:
@tombeckenham tombeckenham self-assigned this Nov 20, 2024
@tombeckenham tombeckenham moved this to Todo in Flow Wallet Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant