You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The same ESlint settings have been used across all three areas of the extension. This allows code to be mixed that shouldn't, applies some rules to the background that shouldn't (like hooks), and prevents usage of window on ui.
Expected experience
ESlint should prevent the ui from directly including code from background services, and vice versa. Rules of hooks should only apply to the popup. Globals should be allowed in the popup
Steps To Reproduce
Include a file from backround in the UI - eslint doesn't complain and it should
Try creating a function starting with "use" in the backgrond - eslint complains when it shouldn't
Try using the window global in the popup - eslint complains when it shouldn't
Environment
- OS: Mac
- Node:
- npm:
The text was updated successfully, but these errors were encountered:
Describe the Bug
The same ESlint settings have been used across all three areas of the extension. This allows code to be mixed that shouldn't, applies some rules to the background that shouldn't (like hooks), and prevents usage of window on ui.
Expected experience
ESlint should prevent the ui from directly including code from background services, and vice versa. Rules of hooks should only apply to the popup. Globals should be allowed in the popup
Steps To Reproduce
Environment
The text was updated successfully, but these errors were encountered: