Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Translate transaction notifications and show failures #191

Open
tombeckenham opened this issue Nov 20, 2024 · 2 comments
Open

[FEATURE] Translate transaction notifications and show failures #191

tombeckenham opened this issue Nov 20, 2024 · 2 comments

Comments

@tombeckenham
Copy link
Collaborator

Issue to be solved

Browser notifications sent in listenTransaction are currently only in english, and are only shown when transactions are successful. Nothing is shown for failed transactions

Suggest A Solution

Ensure all notifications sent in listenTransaction are translated into all languages and use the translation file. Create notifications for failed transactions as well
@tombeckenham
Copy link
Collaborator Author

Here's all the instances of where listenTransaction is called and the notifications messages that are displayed

54 results - 31 files.txt

@tombeckenham
Copy link
Collaborator Author

Search (listenTransaction\(\s\n*\s*\w*,\n*\s*true,\n*\s*)([`'][^`']+[`'])(,\n*\s*)([`'][^`']+[`'])

@tombeckenham tombeckenham moved this to Todo in Flow Wallet Nov 20, 2024
@tombeckenham tombeckenham mentioned this issue Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Flow Wallet
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tombeckenham