Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Incorrect Storage Alert Popup for Non-FLOW Token Transfers #225

Open
Peppermint1020 opened this issue Nov 27, 2024 · 0 comments
Open
Assignees
Milestone

Comments

@Peppermint1020
Copy link
Collaborator

Peppermint1020 commented Nov 27, 2024

Description:
When transferring non-FLOW tokens (FT), the storage alert incorrectly pops up under certain conditions. Specifically, if the user attempts to send the maximum amount of an FT, the storage alert is triggered, even though it appears to incorrectly apply the minimum storage requirement for FLOW tokens. The storage alert should only be displayed when the FLOW token balance is insufficient to meet the storage requirement, not when transferring other FTs.

Steps to Reproduce:

(1) Log in to an account with sufficient FLOW balance to cover storage.
(2) Attempt to send the maximum amount of a non-FLOW token (e.g., another FT).
(3) Observe the storage alert popup.
Expected Behavior:
The storage alert should only be displayed if the FLOW token balance falls below the required storage threshold. It should not be triggered during FT transfers unless FLOW token storage requirements are genuinely unmet.

Actual Behavior:
The storage alert pops up incorrectly during non-FLOW token transfers, even when the FLOW token balance is sufficient to meet the storage requirement.

Version: prod version 2.5.22

@Peppermint1020 Peppermint1020 converted this from a draft issue Nov 27, 2024
@Peppermint1020 Peppermint1020 changed the title [FEATURE] When transfer other ft, the storage alert popup incorrectly [FEATURE] Incorrect Storage Alert Popup for Non-FLOW Token Transfers Nov 27, 2024
@tombeckenham tombeckenham moved this from Todo to In Progress in Flow Wallet Nov 29, 2024
@tombeckenham tombeckenham added this to the Storage Alert milestone Nov 29, 2024
tombeckenham added a commit that referenced this issue Nov 30, 2024
tombeckenham added a commit that referenced this issue Nov 30, 2024
@tombeckenham tombeckenham moved this from In Progress to Code Review in Flow Wallet Nov 30, 2024
@tombeckenham tombeckenham moved this from Code Review to Ready for QA in Flow Wallet Nov 30, 2024
@Peppermint1020 Peppermint1020 moved this from Ready for QA to In QA in Flow Wallet Dec 3, 2024
@Peppermint1020 Peppermint1020 self-assigned this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In QA
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants