589 Add backup flow after account creation #615
Conversation
FRW/Tools/Threading.swift
Outdated
|
|
||
| DispatchQueue.main.async { | ||
| self.changeBackupTypeIfNeeded() | ||
| self.state.isRegisting = false | ||
| Router.popToRoot() | ||
|
|
There was a problem hiding this comment.
I thought about that, but it worked without any issue in my testing. Maybe I can test on a couple more devices and iOS versions, just to be sure
|
It feels wired to jump back to root can then instantly go to backup page. |
THe problem with this is that when the backup screen is dismissed, it will get back to the account creation screen, and from that point on it should redirect to home. I'll check if that can be done without any weird transition |
|
@lmcmz How about this? updated.create.wallet.7.mov |
|
Hey @jeden -- Let's please ensure there is no "sliding" animation shown. The Backup view needs to be immediately displayed once the user selects to Backup |
|
Can we also change the copy on the final account creation view to "Congratulations! Your Flow account is now ready. To best secure your account, you can back it up now." |
|
We can override the navigation stack to avoid user go to back the account creation page. |
# Conflicts: # FRW/Modules/Wallet/CreateAccount/CreateProfileWaitingViewModel.swift
FRW/Services/Router/Router.swift
Outdated
| @@ -47,6 +47,35 @@ extension Router { | |||
| } | |||
| } | |||
|
|
|||
| static func popToRootAndRoute(to target: RouterTarget, animated: Bool = true) { | |||
There was a problem hiding this comment.
Please use setViewControllers to reset the navigation stack.
You can refer to
FRW-iOS/FRW/Services/Router/RouteMap.swift
Lines 142 to 149 in 86bdf99
Related Issue
Summary of Changes
Modified
CreateProfileWaitingViewto show the two buttons, and handled the added route in sequence after showing the home screen.Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)
Before:
current.create.wallet.flow.mov
After:
updated.create.wallet.mov