Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open.gl: Ad messes with sidebar #68

Open
ghost opened this issue Sep 1, 2019 · 5 comments
Open

Open.gl: Ad messes with sidebar #68

ghost opened this issue Sep 1, 2019 · 5 comments

Comments

@ghost
Copy link

ghost commented Sep 1, 2019

There's an ad in the side bar that doesn't want to stay there
image

It disappears when zooming in (thanks to responsive layout mentioned in #48 ?), and doesn't obscure any text, but is still annoying.
I don't know exactly where the problem comes from, but found an oversized <iframe>:

<div id="adbox" class="adbox-side" ...> [160x600]
 <div ...> [160x250]
  <div id="google_ads_iframe_/..."> [160x250]
   <iframe id="google_ads_iframe_/..." ... width="300" height="250"> [300x250]

At least, that's how it works in
Tor Browser 8.5.4 (based on Mozilla Firefox 60.8.0esr) (64-bit)
Cannot check in other browsers since opening the website without VPN gives "connection timed out" for some reason (probably my provider carpet banning all websites on a single IP to satisfy the government's demands)

@Overv
Copy link
Owner

Overv commented Sep 1, 2019

Is this in a browser window that leaves little space to the left of the sidebar? I've tried to reproduce this with a small browser window (just wide enough to show the entire page) but I can't get ads to show up in that case.

@ghost
Copy link
Author

ghost commented Sep 1, 2019

Actually, it is in a big browser window
image
Shrinking it beyond ~1900px makes ads disappear

@Overv
Copy link
Owner

Overv commented Sep 1, 2019

Strange, for me the ads are aligned so that they never cover the text:

@ghost
Copy link
Author

ghost commented Sep 1, 2019

Huh. Maybe Tor breaks something...
There's a message in the console that appears on all pages and might be related

The character encoding of the plain text document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the file needs to be declared in the transfer protocol or file needs to use a byte order mark as an encoding signature.
The character encoding of a framed document was not declared. The document may appear different if viewed without the document framing it.

Also, adding align="right" to the iframe seemed to fix it:
image

@Overv
Copy link
Owner

Overv commented Sep 2, 2019

Ah, that's gonna be a challenge though because I don't think I can apply styling to that iframe myself (it's created by Google AdSense).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant