datastore tag on virtualdisk measurement incorrect on VMs with disks in multiple datastores

[sleepinggenius2]

We have VMs with virtual disks attached out of multiple datastores. It looks like the code is assigning a single datastore value for each VM, instead of assigning per virtual disk. This is causing issues with our IOPs graphs, as the datastores are not correctly tagged.

Expected:
(*client.Point)(0xc4202c2e70)(virtualdisk,cluster=Cluster1,datastore=DS2,esx=hv1,host=vcenter,instance=scsi0:1,name=testvm,respool=Resources ...
(*client.Point)(0xc4202c2e80)(virtualdisk,cluster=Cluster1,datastore=DS1,esx=hv1,host=vcenter,instance=scsi0:0,name=testvm,respool=Resources ...

Actual:
(*client.Point)(0xc4202c2e70)(virtualdisk,cluster=Cluster1,datastore=DS2,esx=hv1,host=vcenter,instance=scsi0:1,name=testvm,respool=Resources ...
(*client.Point)(0xc4202c2e80)(virtualdisk,cluster=Cluster1,datastore=DS2,esx=hv1,host=vcenter,instance=scsi0:0,name=testvm,respool=Resources ...

vsphere-influxdb-go/vsphere-influxdb.go

Line 454 in 72f6283

vmSummary[vm.Self]["datastore"] = strings.Replace(strings.Replace(re.FindString(fmt.Sprintln(vm.Summary.Config)), "[", "", -1), "]", "", -1)

[sofixa]

Hi,

Yeah, sorry, that's something i noted some time ago and completely forgot about since we never use vdisks on different datastores. I'll try to fix it these days.

Cheers,
Adrian