Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for non-comma separators #49

Open
robwyse opened this issue Nov 29, 2019 · 2 comments
Open

Allow for non-comma separators #49

robwyse opened this issue Nov 29, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@robwyse
Copy link

robwyse commented Nov 29, 2019

As it currently stands, a CSV file with a non-comma separator will return "no valid row found in the CSV file". Given that Excel uses a semicolon as CSV separator by default when comma is used the decimal separator, as is the case in e.g. the default Dutch language settings, being able to parse such CSV files without having to replace all semicolons with commas would increase user friendliness, especially for less tech-savvy users.

@nvanderperren
Copy link
Contributor

nvanderperren commented Nov 29, 2019

We are aware of this Microsoft problem, but for now I would advise to use LibreOffice or Google Sheets to create CSV's or transform Excel CSV's. We will point this out in the wiki.

We are using an already existing npm module to parse csv's that only supports comma seperated values documents. Maybe in the near future, we could look how we could support the Excel CSV. (Excel is just not a good tool for creating CSV's).

@nvanderperren nvanderperren added the enhancement New feature or request label Nov 29, 2019
@robwyse
Copy link
Author

robwyse commented Dec 2, 2019

I've done some playing around, and found that with csv-parse you can set the separator character via the "delimiter" option. This opens up the possibility of letting the user choose the separator, perhaps under the advanced options, with comma as the default value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants