Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes bug - Camera params get overridden when changing dimension #75

Closed
wants to merge 1 commit into from
Closed

Fixes bug - Camera params get overridden when changing dimension #75

wants to merge 1 commit into from

Conversation

murtazaqa
Copy link

@murtazaqa murtazaqa commented Jun 22, 2021 •
edited
Loading

Camera parameters passed in the constructor get overridden when changing dimensions.
Fixes #74

@murtazaqa
Fixed bug - Saving camera params
16be50d 
passed in the constructor and using
@murtazaqa murtazaqa changed the title Fixes bug - Camera params getting overridden when changing dimension Fixes bug - Camera params get overridden when changing dimension Jun 22, 2021
murtazaqa
murtazaqa commented Jun 22, 2021
View reviewed changes
Copy link
Author

@murtazaqa murtazaqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have simply stored the camera params in a variable and used the same whenever makeCamera() method is called.

@cannoneyed cannoneyed closed this Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changing dimension from 3D to 2D do not retain the camera parameters passed in the constructor
2 participants
@murtazaqa @cannoneyed