From c7b9ee92b7f25aae312f7d0f292d6d3d7b1c8c08 Mon Sep 17 00:00:00 2001
From: KamFretoZ <14798312+kamfretoz@users.noreply.github.com>
Date: Sat, 26 Oct 2024 19:37:40 +0700
Subject: [PATCH] Qt: Properly Grey Out Checkboxes When Perf OSD is Disabled

---
 pcsx2-qt/Settings/GraphicsSettingsWidget.cpp |  2 +
 pcsx2-qt/Settings/GraphicsSettingsWidget.ui  | 92 ++++++++++----------
 2 files changed, 48 insertions(+), 46 deletions(-)

diff --git a/pcsx2-qt/Settings/GraphicsSettingsWidget.cpp b/pcsx2-qt/Settings/GraphicsSettingsWidget.cpp
index 6307c6beb80d5..311143fd46f22 100644
--- a/pcsx2-qt/Settings/GraphicsSettingsWidget.cpp
+++ b/pcsx2-qt/Settings/GraphicsSettingsWidget.cpp
@@ -931,12 +931,14 @@ void GraphicsSettingsWidget::onPerformancePosChanged()
 {
 	const bool enabled = m_ui.osdPerformancePos->currentIndex() != (m_dialog->isPerGameSettings() ? 1 : 0);
 
+	m_ui.osdShowVPS->setEnabled(enabled);
 	m_ui.osdShowSpeed->setEnabled(enabled);
 	m_ui.osdShowFPS->setEnabled(enabled);
 	m_ui.osdShowCPU->setEnabled(enabled);
 	m_ui.osdShowGPU->setEnabled(enabled);
 	m_ui.osdShowResolution->setEnabled(enabled);
 	m_ui.osdShowGSStats->setEnabled(enabled);
+	m_ui.osdShowHardwareInfo->setEnabled(enabled);
 	m_ui.osdShowIndicators->setEnabled(enabled);
 	m_ui.osdShowFrameTimes->setEnabled(enabled);
 	m_ui.osdShowVersion->setEnabled(enabled);
diff --git a/pcsx2-qt/Settings/GraphicsSettingsWidget.ui b/pcsx2-qt/Settings/GraphicsSettingsWidget.ui
index e097717193e81..d1b6a9031d041 100644
--- a/pcsx2-qt/Settings/GraphicsSettingsWidget.ui
+++ b/pcsx2-qt/Settings/GraphicsSettingsWidget.ui
@@ -7,7 +7,7 @@
     <x>0</x>
     <y>0</y>
     <width>720</width>
-    <height>562</height>
+    <height>594</height>
    </rect>
   </property>
   <layout class="QVBoxLayout" name="verticalLayout">
@@ -1632,17 +1632,17 @@
           </item>
           <item row="3" column="0" colspan="2">
            <layout class="QGridLayout" name="osdOptionLayout">
-            <item row="6" column="1">
-             <widget class="QCheckBox" name="osdShowVideoCapture">
+            <item row="2" column="1">
+             <widget class="QCheckBox" name="osdShowSpeed">
               <property name="text">
-               <string>Show Video Capture Status</string>
+               <string>Show Speed Percentages</string>
               </property>
              </widget>
             </item>
-            <item row="1" column="1">
-             <widget class="QCheckBox" name="osdShowGPU">
+            <item row="6" column="1">
+             <widget class="QCheckBox" name="osdShowVideoCapture">
               <property name="text">
-               <string>Show GPU Usage</string>
+               <string>Show Video Capture Status</string>
               </property>
              </widget>
             </item>
@@ -1653,94 +1653,94 @@
               </property>
              </widget>
             </item>
-            <item row="4" column="1">
-             <widget class="QCheckBox" name="osdShowInputs">
+            <item row="3" column="0">
+             <widget class="QCheckBox" name="osdShowIndicators">
               <property name="text">
-               <string>Show Inputs</string>
+               <string>Show Indicators</string>
               </property>
              </widget>
             </item>
-            <item row="2" column="1">
-             <widget class="QCheckBox" name="osdShowSpeed">
+            <item row="0" column="1">
+             <widget class="QCheckBox" name="osdShowFPS">
               <property name="text">
-               <string>Show Speed Percentages</string>
+               <string>Show FPS</string>
               </property>
              </widget>
             </item>
-            <item row="6" column="0">
-             <widget class="QCheckBox" name="osdShowHardwareInfo">
+            <item row="0" column="0">
+             <widget class="QCheckBox" name="osdShowVPS">
               <property name="text">
-               <string>Show Hardware Info</string>
+               <string>Show VPS</string>
               </property>
              </widget>
             </item>
-            <item row="5" column="0">
-             <widget class="QCheckBox" name="osdShowFrameTimes">
+            <item row="4" column="1">
+             <widget class="QCheckBox" name="osdShowInputs">
               <property name="text">
-               <string>Show Frame Times</string>
+               <string>Show Inputs</string>
               </property>
              </widget>
             </item>
-            <item row="3" column="1">
-             <widget class="QCheckBox" name="osdShowSettings">
+            <item row="6" column="0">
+             <widget class="QCheckBox" name="osdShowHardwareInfo">
               <property name="text">
-               <string>Show Settings</string>
+               <string>Show Hardware Info</string>
               </property>
              </widget>
             </item>
-            <item row="7" column="0">
-             <widget class="QCheckBox" name="warnAboutUnsafeSettings">
+            <item row="1" column="1">
+             <widget class="QCheckBox" name="osdShowGPU">
               <property name="text">
-               <string>Warn About Unsafe Settings</string>
+               <string>Show GPU Usage</string>
               </property>
              </widget>
             </item>
-            <item row="3" column="0">
-             <widget class="QCheckBox" name="osdShowIndicators">
+            <item row="1" column="0">
+             <widget class="QCheckBox" name="osdShowCPU">
               <property name="text">
-               <string>Show Indicators</string>
+               <string>Show CPU Usage</string>
               </property>
              </widget>
             </item>
-            <item row="1" column="0">
-             <widget class="QCheckBox" name="osdShowCPU">
+            <item row="3" column="1">
+             <widget class="QCheckBox" name="osdShowSettings">
               <property name="text">
-               <string>Show CPU Usage</string>
+               <string>Show Settings</string>
               </property>
              </widget>
             </item>
-            <item row="4" column="0">
-             <widget class="QCheckBox" name="osdShowGSStats">
+            <item row="5" column="0">
+             <widget class="QCheckBox" name="osdShowFrameTimes">
               <property name="text">
-               <string>Show Statistics</string>
+               <string>Show Frame Times</string>
               </property>
              </widget>
             </item>
-            <item row="0" column="1">
-             <widget class="QCheckBox" name="osdShowFPS">
+            <item row="2" column="0">
+             <widget class="QCheckBox" name="osdShowResolution">
               <property name="text">
-               <string>Show FPS</string>
+               <string>Show Resolution</string>
               </property>
              </widget>
             </item>
-            <item row="7" column="1">
-             <widget class="QCheckBox" name="osdShowVersion">
+            <item row="4" column="0">
+             <widget class="QCheckBox" name="osdShowGSStats">
               <property name="text">
-               <string>Show PCSX2 Version</string>
+               <string>Show Statistics</string>
               </property>
              </widget>
             </item>
-            <item row="2" column="0">
-             <widget class="QCheckBox" name="osdShowResolution">
+            <item row="8" column="0">
+             <widget class="QCheckBox" name="osdShowVersion">
               <property name="text">
-               <string>Show Resolution</string>
+               <string>Show PCSX2 Version</string>
               </property>
              </widget>
             </item>
-            <item row="0" column="0">
-             <widget class="QCheckBox" name="osdShowVPS">
+            <item row="8" column="1">
+             <widget class="QCheckBox" name="warnAboutUnsafeSettings">
               <property name="text">
-               <string>Show VPS</string>
+               <string>Warn About Unsafe Settings</string>
               </property>
              </widget>
             </item>