Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Spirv dependency & Support TaskEXT, MeshEXT execution models? #127

Closed
codecnotsupported opened this issue Mar 5, 2024 · 3 comments · Fixed by #128 or #132
Closed

Update Spirv dependency & Support TaskEXT, MeshEXT execution models? #127

codecnotsupported opened this issue Mar 5, 2024 · 3 comments · Fixed by #128 or #132

Comments

@codecnotsupported
Copy link

codecnotsupported commented Mar 5, 2024

I noticed that spirq's Spirv dependency is out of date when mapping spirq::spirv::ExecutionModel to ash::vk::ShaderStageFlags missing TaskEXT, MeshEXT.
Can the version be bumped?

spirv = "0.2"

@PENGUINLIONG
Copy link
Owner

Sure. Please feel free to make a pull request or I can help with that a couple of hours later.

@PENGUINLIONG
Copy link
Owner

It seems it's much more difficult than I thought to upgrade to spirv 0.3 since it removed all FromPrimitive impls.. Will deal with it a bit later

@codecnotsupported
Copy link
Author

It seems it's much more difficult than I thought to upgrade to spirv 0.3 since it removed all FromPrimitive impls.. Will deal with it a bit later

Thanks. I was struggling to make head & tails on how to deal with gfx-rs/rspirv#219 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants