Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TcpListerner reconnects connection immediately if validation failed #296

Open
dbeuchler opened this issue Jun 23, 2023 · 0 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@dbeuchler
Copy link
Member

Is your feature request related to a problem? Please describe.

The TcpListener reconnects the connection immediately if validation failed by the validator. The connection on a PLC for example flickers if the validation fails. To reconnect, is a good way to inform the peer about an issue. This fast flicker is really hard to debug and to handle. It is not possible to influence this behavior.

A PLC for example could get a "Nack" and "Exception" before closing the connection.

https://github.com/PHOENIXCONTACT/MORYX-Framework/blob/dev/src/Moryx/Communication/Sockets/Server/TcpListenerConnection.cs#L262

Describe the solution you'd like

  1. Reconnect should also use the Reconnect-Timer.
  2. It would be nice if a "last will" or "error handling" action can be performed by upper layers
@dbeuchler dbeuchler added the enhancement New feature or request label Jun 23, 2023
@dbeuchler dbeuchler self-assigned this Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant