-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prism syntax highliting #3657
Comments
Wow, @vanillajonathan already created a PR for this! (PrismJS/prism#3736) |
TODO: Enable prql syntax highlighting on ClickHouse documents (https://github.com/ClickHouse/clickhouse-docs/blob/44fb2eefa08e8d6037c91958292ccca40003f294/docusaurus.config.js#L214) once this is available from Docusaurus |
Prism is working on Prism v2 so they're no longer accepting any contributions to v1. My PR is against the v2 branch, I hope it will get merged. There is a roadmap but no information about when v2 will be released. PrismJS/prism#3531 (Roadmap for Prism v2) |
I see, thank you for the explanation (I don't remember it at all, but there was evidence that I responded to that discussion). Maybe it's possible to keep it here or another repo like https://github.com/SassDoc/prism-scss-sassdoc if it's not merged? |
Yes, I suppose so, but my intention and hope is for the PR to be merged upstream so that it will be readily and easily available downstreams without additional setup, configuration or packages. Note that clickhouse-docs uses Prism v1 and my PR is for Prism v2. We could create a syntax highlight definition for v1, but without it being available upstream it would be more burden on downstream users of Prism to use our syntax highlighting. |
Thanks, it seems that Docusaurus depends on prism vendored version on Perhaps it will take a while to reach Docusaurus here after the PRs are merged. |
https://prismjs.com/#supported-languages
Prism is used by Docusaurus, a popular static site generator.
Here is an example of third-party syntax that should be able to support PRQL in the same way.
https://github.com/SassDoc/prism-scss-sassdoc
The text was updated successfully, but these errors were encountered: