Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shuffled module names in signalomes() and plotSignalomeMap() output figures #7

Open
IwanParf opened this issue Apr 23, 2022 · 4 comments

Comments

@IwanParf
Copy link

Hello,
this is a great tool, kudos!
I have a minor bug to report. When running the signalomes function, the resulting module names are integers (but not necessarily consecutive numbers, e.g. 1, 2, 5, 12, 37) and are also sorted as numeric values. If one then takes its output for plotSignalomeMap(), the module names are consecutive numbers starting from 1 that are sorted as character, e.g. 1, 10, 11, 12 ..., 2, 20, 21, 22 etc.. Thus, the order in the signalome figure is not the same as the order in the balloon plot from plotSignalomeMap, if the module names exceed 9 (obviously, module numbers within the range of 1 to 9 are sorted correctly in any way). One can circumvent it by specifying module_res, then the module names are consecutive numbers and keeping the number of modules at max 9, so it will be ordered correctly.

Best,

Iwan

@HaniJieunKim
Copy link
Collaborator

Thanks @IwanParf for reporting the bug! I'll sort it out sometime this week.

@HaniJieunKim
Copy link
Collaborator

Hi @IwanParf

I wasn't able to reproduce this error. It seems alright on my side when I generate the signalome figure and the plot from plotSignalomeMap for cluster number great than 9.

Could you share a reproducible code I could test?

Many thanks,

Hani

@IwanParf
Copy link
Author

IwanParf commented Jun 2, 2022

Hello Hani,
I am sorry for replying so late. I am going to provide a code example in the following days, but here's already a picture visualizing what I meant. The order for the signalome and balloon plot is different

image

@IwanParf
Copy link
Author

IwanParf commented Jun 2, 2022

Now, when I provide module_res = 9 (Only 8 modules shown, I guess one is dropped due to filtering), I get consecutive numbers in the signalome and the same order in both figures (e.g. module 3 is also module 3 on the right):

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants