From c3f14ba2a716f03faed5dfa6787c71f9a7ee1513 Mon Sep 17 00:00:00 2001
From: lynxnb <niccolo.betto@gmail.com>
Date: Thu, 24 Aug 2023 13:03:36 +0200
Subject: [PATCH] Remove hasFragileUserData from the app manifest

It was effectively unused, and only caused issues for users, even after proper implementation that enabled it on signed builds only.
---
 app/build.gradle                 | 11 +++--------
 app/src/main/AndroidManifest.xml |  1 -
 2 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/app/build.gradle b/app/build.gradle
index 362acd8f3..21a098de9 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -33,13 +33,8 @@ android {
             abiFilters "arm64-v8a"
         }
 
-        if (isBuildSigned)
-            manifestPlaceholders += [shouldSaveUserData: "true"]
-        else
-            manifestPlaceholders += [shouldSaveUserData: "false"]
-
-        // Only enable separate process for release builds
-        manifestPlaceholders += [emulationProcess: ""]
+        // Disable the use of a separate process for emulation by default
+        manifestPlaceholders["emulationProcess"] = ""
 
         def locales = ["en", "de", "el", "es", "es-419", "fr", "hu", "id", "it", "ja", "ko", "pl", "ru", "ta", "zh-Hans", "zh-Hant"]
 
@@ -85,7 +80,7 @@ android {
             shrinkResources true
             proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
             signingConfig = isBuildSigned ? signingConfigs.ci : signingConfigs.debug
-            manifestPlaceholders += [emulationProcess: ":emulationProcess"]
+            manifestPlaceholders["emulationProcess"] = ":emulationProcess"
         }
 
         reldebug {
diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index e117e3f56..0a0621bbb 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -17,7 +17,6 @@
         android:allowBackup="true"
         android:extractNativeLibs="true"
         android:fullBackupContent="@xml/backup_descriptor"
-        android:hasFragileUserData="${shouldSaveUserData}"
         android:icon="@drawable/logo_skyline"
         android:isGame="true"
         android:label="@string/app_name"