Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent changes to the funnel configuration that can break determinism #398

Open
ecioppettini opened this issue Jul 19, 2024 · 0 comments
Open

Comments

@ecioppettini
Copy link
Contributor

Currently the funnel/networks configuration has some variables that can't be changed after the first setup. For example, changing the delay setting will change the block mapping from parallel networks to the main one. Also with the recent introduction of transaction hashes, some parameters like the chainId shouldn't also be changed. Additionally, changing the order of the entries in the file could also lead to different order of events.

We can't just store a hash of the config like with the extensions though, since there are some settings that should be allowed to change (the rpc endpoint, rate-limiting parameters, etc).

We may want to do something like:

  • Store the configurations in a new table in the db, and on startup validate only the settings that can't change. Also validate the order.
  • Store only the things that can't change and validate those.
  • Store a hash of the subset of the elements that can't change (maybe normalized)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant