Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests should use random ports #73

Open
EdHurtig opened this issue Nov 12, 2017 · 4 comments
Open

Integration tests should use random ports #73

EdHurtig opened this issue Nov 12, 2017 · 4 comments
Assignees
@shorstman
Labels
Testing

Comments

@EdHurtig
Copy link
Member

For the time being, the integration tests should use randomized ports for Logging and Commands. This will allow mutilple jobs to coexist without deadlocking each other.

In the future we will contain these jobs on the Jenkins server in individual docker containers, etc
@EdHurtig
Copy link
Member Author

Related to #62

@shorstman shorstman self-assigned this Nov 12, 2017
@shorstman
Copy link
Member

Is there a range of valid ports/any ports that shouldn't be tested?

@EdHurtig EdHurtig mentioned this issue Nov 12, 2017
Merged
@EdHurtig
Copy link
Member Author

uh anything in the unprivileged port range (I think anything above 1024 IIRC) is fine. Probably best to restrict the range to something like 20,000 to 30,000 and check the random port before starting the test.

All this logic of port selection can be done in ControllerTest.py

@EdHurtig
Copy link
Member Author

Alternatively... could use this plugin
https://wiki.jenkins.io/display/JENKINS/Port+Allocator+Plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shorstman shorstman

Labels
Testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EdHurtig @shorstman