Externally managed SNS/SQS clients were disposed when experimental constructor added in 7.1.0 #2638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonsmits
force-pushed
the
fix-dispose
branch
from
a3f4d7c to
789afca
Compare
ramonsmits
requested review from
SzymonPobiega,
WilliamBZA,
tmasternak and
irinascurtu
WilliamBZA
approved these changes
Nov 27, 2024
ramonsmits
force-pushed
the
fix-dispose
branch
from
789afca to
1f34143
Compare
…bool) constructor set fields instead of property
ramonsmits
force-pushed
the
fix-dispose
branch
from
1f34143 to
fed8cf2
Compare
WilliamBZA
approved these changes
Nov 27, 2024
Co-authored-by: WilliamBZA <[email protected]>
WilliamBZA
approved these changes
Nov 27, 2024
ramonsmits
added a commit
that referenced
this pull request
Nov 27, 2024
…nstructor added in 7.1.0 (#2638) Co-authored-by: WilliamBZA <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Externally managed SNS/SQS clients were disposed at shutdown when using new
SqsTransport(IAmazonSQS, IAmazonSimpleNotificationService snsClient, bool)constructor in version https://github.com/Particular/NServiceBus.AmazonSQS/releases/tag/7.1.0Symptoms
ObjectDisposedException on SQS and SNS clients after the transport was shutdown.
Who's affected
Users that use the new constructor added in 7.1.0
Root cause
The passed SQS and SNS client referces got disposed when the transport was shutdown as these were not correctly tracked as being "external".