Startup Diagnostics are not reported for NServiceBus v8

[mikeminutillo]

Describe the bug

The transport adds a startup diagnostics section (Azure Service Bus transport) but it is not included in the startup diagnostics reported by the endpoint.

To Reproduce

Create an NServiceBus endpoint using NServiceBus version 8 (or above) configured to us NServiceBus.Transport.AzureServiceBus version 3 (or above).

Start the endpoint

Check the startup diagnostics file. The Azure Service Bus transport section is not included.

Expected behavior

The Azure Service Bus transport section should be included in the endpoint startup diagnostics file.

Versions:

• NuGet package: 3.x

Root cause

This is happening because the transport is adding a startup diagnostic after they have been reported. The transport is not initialized until the call to endpointInstance.Start() here, which is just after the diagnostics are written.

Related Bug: Particular/NServiceBus#6656