Fix Warden Import Colour #8362
Merged
Fix Warden Import Colour #8362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Nov 18, 2024
LocalIdentity
merged commit bd76683
into
PathOfBuildingCommunity:dev
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warden was missing from the list as its "new" and so the colour would be
nilI would prefer to do somthing like
classColor = colorCodes[charClass:upper()] or (main.tree[latestTreeVersion].ascendNameMap[charClass] and colorCodes[main.tree[latestTreeVersion].ascendNameMap[charClass].class.name:upper()]) or colorCodes.DEFAULTinstead of the if statements, but the
ascendNameMapuses the ID not the name, and so raider is the valid class that maps to warden, and requires more extensive changes to work