Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin <-> interrupt mapping seems wrong on atmega1284 #23

Open
v0lker opened this issue Dec 13, 2018 · 3 comments · May be fixed by #24
Open

pin <-> interrupt mapping seems wrong on atmega1284 #23

v0lker opened this issue Dec 13, 2018 · 3 comments · May be fixed by #24

Comments

@v0lker
Copy link

v0lker commented Dec 13, 2018 •
edited
Loading

i connected CLK to the atmega1284 DIP's pin 3 (D2 / INT2), however the interrupt number calculated in PS2Keyboard::begin() was 0, not 2 as expected. took me an awfully long time to realise why ps2interrupt() wasn't called..

i got the desired value by using digitalPinToInterrupt(irq_pin) instead of what most of begin() does - is there any reason not to use the arduino-provided function?
@PaulStoffregen
Copy link
Owner

This library is very old, from long before Arduino had that function.

It should probably be updated. I can tell you I'm not doing any non-critical updates to any libraries until at least mid-2019. Currently working on a hardware project... the type that actually pays the bills, so I can then work on free software at other times. Ping me on this in July 2019.

@v0lker
Copy link
Author

v0lker commented Dec 13, 2018

ah, ok, that makes sense. i'll send you a PR and you can merge it in july if you like...

@v0lker v0lker linked a pull request Dec 13, 2018 that will close this issue
Open
@v0lker
Copy link
Author

v0lker commented Jun 2, 2021

how time flies - ping...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@PaulStoffregen @v0lker