-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating from node-webcrypto-ossl #1
Comments
|
@microshine are you able to build node-webcrypto-ossl for electron on windows? |
@microshine i saw your fortify project and added |
@yalamber You must put |
@yalamber you can take prebuild openssl here https://github.com/PeculiarVentures/fortify/releases |
@microshine Thank you so much. I rebuilt using old version of openssl and it went fine. |
Will this eventually replace node-crypto-ossl? |
Yes, our current thinking is that once all the blocking issues are addressed (assuming that can be done) we will make that switch. Right now some algorithms can't be implemented because of issues in node.crypto and there is an issue with running inside Electron applications. We are not aware of any other issues at this time. |
Are all the blocking issues listed somewhere? Also I'm concerned about whether the crypto API will be truely async across all the platforms. See the concerns listed on this package: https://www.npmjs.com/package/@ronomon/crypto-async |
The current known issues are here: https://github.com/PeculiarVentures/webcrypto/issues?q=is%3Aissue+is%3Aopen+label%3A%22blocking+deprecation+of+node-webcrypto-ossl%22 We have done benchmarking and in all cases, if I recall correctly the performance between node-webcrypto-ossl was essentially the same or marginally faster. I suspect that there will be no issue but we should create a bug to test for this. The desire to deprecate the native c module is based on:
The downsides of doing the switch are (so far):
Were open to different approaches here, we just are trying to help the internet with this library. |
Reopening this issue so people can use it to discuss the topic. |
Now that nodejs has a webcrypto object It seems to rely only on node's I was using It seemed like this was sufficient: import { webcrypto } from 'crypto';
import * as x509 from '@peculiar/x509';
x509.cryptoProvider.set(webcrypto as Crypto); In that case, is there still a reason to use this library if the node version is 16.17+? |
Hello,
I am using pki.js library with node-webcrypto-ossl in an electron app. While using node-webcrypto-ossl on windows for electron it produces various error and I was thinking of migrating to this library. Is there any difference between this library and node-webcrypto-ossl? Will it be fine to use any as replacement in any project?
The text was updated successfully, but these errors were encountered: