feat(PriceRouter): add price router #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sanity checks to Price Router
0xble
reviewed
Jun 21, 2022
0xble
reviewed
Jun 21, 2022
0xble
reviewed
Jun 21, 2022
|
It doesn't look like solidity will revert when doing explicit type conversions, even if the conversion would lose data, or change the sign. So conversions should be handled by internal functions that check to make sure we aren't losing data or changing sign. |
…/cellar-contracts into feat/price-router
…h mulDivDown when needed
…-contracts into feat/price-router
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30