Updates for v4 installation steps #178
Conversation
There was a problem hiding this comment.
New docs are looking good! I have not rebuilt a node using them but took a quick look over the commands and with the addition of the services files you have added the only other comments i could add is propose a change below to replace wildcard with binary name incase 'install' directory exists and contains other files
Original command: wget https://github.com/PeggyJV/steward/releases/download/v2.0.2/steward && chmod +x * && sudo mv * /usr/bin
Proposed command: wget https://github.com/PeggyJV/steward/releases/download/v2.0.2/steward && chmod +x steward && sudo mv steward /usr/bin
Also suggestion for your consideration that creating service account users as part of the process could be a good security improvement as well as allow the docs to contain correct paths when referencing users home directories for keystore and configs currently the process uses a user called ubuntu. This would require a lot of changes to the docs and files and if desirable maybe better added at a later stage so we can ship the changes and get the docs updated.
|
|
||
| # Install Sommelier | ||
| wget https://github.com/PeggyJV/sommelier/releases/download/v3.1.1/sommelier_3.1.1_linux_amd64.tar.gz && tar -xf sommelier_3.1.1_linux_amd64.tar.gz && sudo mv sommelier /usr/bin && rm -rf sommelier_3.1.1_linux_amd64* LICENSE README.md | ||
| wget https://github.com/PeggyJV/sommelier/releases/download/v4.0.1/sommelier_4.0.1_linux_amd64.tar.gz && tar -xf sommelier_4.0.1_linux_amd64.tar.gz && sudo mv sommelier /usr/bin && rm -rf sommelier_4.0.1_linux_amd64* LICENSE README.md |
There was a problem hiding this comment.
It's nice that we provide direct commands, but every time the version of the node bumps (e.g. we just had a patch update for Dragonberry) we'd have to update these commands. Is there a way to point to "latest" or something?
There was a problem hiding this comment.
There is a latest page but I don't see how you could select a specific binary architecture without being explicit about the file name. Maybe we just make this a manual step?
| # - a key named "validator" with funds on the cosmos chain in the sommelier keystore | ||
|
|
||
| # Add the peers from contrib/mainnet/sommelier-3/peers.txt to the ~/.sommelier/config/config.toml file | ||
| nano ~/.sommelier/config/config.toml | ||
|
|
||
| # pull the genesis file | ||
| # pull the genesis file |
There was a problem hiding this comment.
Given there has been an upgrade in the intervening time, I don't think downloading the v4 binary will work for syncing from the genesis, which started on v3. Should we provide some instructions to use Cosmovisor or how to handle this manually?
| $(steward --config $HOME/steward/config.toml keys eth show signer) \ # eth signer address | ||
| $(steward --config $HOME/steward/config.toml sign-delegate-keys signer $(sommelier keys show validator --bech val -a)) \ | ||
| --chain-id sommelier-3 \ | ||
| --from validator \ |
There was a problem hiding this comment.
IIRC some folks were having issues with setting gas correctly for set-delegate-keys, do we need to specify it manually?
| @@ -161,7 +182,7 @@ gorc eth-to-cosmos \ | |||
| --erc20-address="0x0000000000000000000000000000000000000000" \ | |||
| --amount="1.3530000" \ | |||
| --cosmos-destination="$(sommelier keys show orchestrator -a)" | |||
|
|
|||
There was a problem hiding this comment.
We may want to remove these from the default README, there's really no need for an individual validator to bridge assets during their setup, and the extra traffic spends ETH.
|
|
||
| [keys] | ||
| delegate_key = "orchestrator" # Edit if your orchestrator's Cosmos key name is different |
There was a problem hiding this comment.
Should we add a comment indicating delegate_key is only used by steward and not the orchestrator?
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Closes #124