New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nit: x/auction/keeper: Keeper.EndBlocker could succinctly use !sdk.Dec.IsPositive and not having to compare against a zero magnitude sdk.Dec #296

Open

odeke-em opened this issue Mar 15, 2024 · 0 comments

odeke-em commented Mar 15, 2024 •

edited

Loading

Noticed here that we've got this comparison

sommelier/x/auction/keeper/abci.go

Line 39 in 3157d97

if newUnitPriceInUsomm.LTE(sdk.NewDec(0)) {

but really that can be succinctly and cheaply be turned into !.IsPositive()

odeke-em changed the title ~~nit: x/auction/keeper: Keeper.EndBlocker could succinctly use sdk.Dec.IsNegative and not having to compare against a zero magnitude sdk.Dec~~ nit: x/auction/keeper: Keeper.EndBlocker could succinctly use !sdk.Dec.IsPositive and not having to compare against a zero magnitude sdk.Dec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment