This repository has been archived by the owner on Oct 27, 2023. It is now read-only.
Fix the issue with linking against both Lightning-Kokkos and Lightning #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
…kos into multidev/fix_buildw_lightning_new
vincentmr
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
Looks good to me. I have a few questions, essentially about formatting. I'm guessing that Kokkos:: was replaced by ::Kokkos:: with sed or a similar command without much discrimination. I'm wondering if any issue could arise from that in the long run, or if it shows poor style (e.g. in the docstrings). I'd be OK merging as is, but I wonder what are people's thoughts.
pennylane_lightning_kokkos/src/algorithms/AdjointDiffKokkos.cpp
Outdated
Show resolved
Hide resolved
…kos into multidev/fix_buildw_lightning_new
…aneAI/pennylane-lightning-kokkos into multidev/fix_buildw_lightning_new
|
Note |
multiphaseCFD
approved these changes
Apr 26, 2023
…ng-kokkos into multidev/fix_buildw_lightning_new
AmintorDusko
approved these changes
Apr 27, 2023
There was a problem hiding this comment.
Thank you, @maliasadi. On a curious note, changing ::Kokkos back to Kokkos decreased the changes introduced by this PR from +1180 -1116 to +176 -145. A reduction of more than one thousand lines. 😱
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we cannot build and link both Lightning and Lightning-Kokkos in a single translation unit due to conflicts in the name of files, functions, classes, and namespaces. This PR addresses this issue. A direct use case of this patch would be in getting support for both
lightning.qubitandlightning.kokkossimulators in Catalyst.[sc-37004]