Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Enhancement) Support for overlays for blocks with different position on 2 axis #464

Open
djmrFunnyMan opened this issue Jul 4, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@djmrFunnyMan
Copy link

djmrFunnyMan commented Jul 4, 2024

Currently CT only works when the blocks are off by 1 block on 1 axis (ie. their faces are parallel to each other)

It would be great if CT could be made to work even on blocks which are off by 1 block on 2 axis (ie. their faces are perpendicular to each other). This should require the RSP to inform the mod if a particular CT should apply to perpenducular blocks as it probably wouldn't always be desirable. This also means this new feature wouldn't retroactively change the look of CT texture packs.

This be a big feature but it would easily make continuity the best connected textures mod out there as none other have this.
Ik you're not exactly planning on adding such things rn but if you ever consider adding more features beyond what optifine has this'd be great

2024-05-31_00 00 21
2024-05-31_00 00 20
2024-05-30_23 56 29

@PepperCode1
Copy link
Owner

PepperCode1 commented Jul 4, 2024

First of all, I assume you are talking specifically about method=overlay. I assume the logic of the feature works such that first, the offset block is checked for whether it applies an overlay; if not and the offset block is not considered an obscuring block, check whether the directly adjacent block applies an overlay.

I was doing method=overlay testing and optimization just recently and had exactly this idea (if the above assumptions are correct). The following screenshot shows an example.

This feature would be enabled via a boolean property in the CTM file and the default should be false. Do you have ideas for a name for this property? Property names should be short (16 characters or less; multiple words can be combined with camelCase) but informative.

@PepperCode1 PepperCode1 added the enhancement New feature or request label Jul 4, 2024
@djmrFunnyMan djmrFunnyMan changed the title (Enhancement) Support for connected textures for blocks with different position on 2 axis (Enhancement) Support for overlays for blocks with different position on 2 axis Jul 4, 2024
@djmrFunnyMan
Copy link
Author

You are correct.
Anyway my name ideas are:

  • perpendicularOverlay
  • perpendicularMatch
  • matchDiagonal
  • extendedMatch
  • enhancedMatch

@djmrFunnyMan
Copy link
Author

djmrFunnyMan commented Jul 5, 2024

  • omnidirectionalCTM
  • unrestrictedMatch
  • matchAllAround
  • fullMatching
  • doRightAngles

And many other combinations using words above in different order

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants