-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pRPC AllowHandoverTo #1500
Open
kvinwang
wants to merge
10
commits into
master
Choose a base branch
from
council-signed-handover
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add pRPC AllowHandoverTo #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvinwang
force-pushed
the
council-signed-handover
branch
3 times, most recently
from
December 27, 2023 10:32
41591a2
to
fb2640e
Compare
kvinwang
force-pushed
the
council-signed-handover
branch
from
December 28, 2023 02:11
2eae99d
to
4a438bc
Compare
7 tasks
kvinwang
force-pushed
the
ident-addr-mapping
branch
from
January 3, 2024 02:14
e11e27a
to
b5b0144
Compare
kvinwang
force-pushed
the
council-signed-handover
branch
from
January 4, 2024 07:48
4a438bc
to
46c117a
Compare
shelvenzhou
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a pruntime RPC named AllowHandoverTo. It allows the council members to sign a new version of pRuntime in order to enable them to hand over the key when pRuntime encounters issues syncing block data.
This is part of #1499.
Usage
Suppose we have two version of pRuntime A and B, where A is stucked, and we want to force handover to B.
SGX MR of A: 0x10c24c0e6bf8a86634417fcd8f934e62439c62907a6f1bc726906a50b054ddf10000000083d719e77deaca1470f6baf62a4d774303c899db69020f9c70ee1dfc08c7ce9e
SGX MR of B: 0xf42f7e095735702d1d3c6ac5fa3b4581d3c3673d3c5ce261a43fe782ccb3e1dc0000000083d719e77deaca1470f6baf62a4d774303c899db69020f9c70ee1dfc08c7ce9e
Genisis block hash: 0x0a15d23307d533d581291ff6dedca9ca10927c7dff6f4df9e8c3bf00bc5a6ded (Can be got via get_info)
Then the steps would be:
See https://files.kvin.wang:8443/signit/ for an example
$ ./gramine-sgx pruntime --request-handover-from http://localhost:8000