Skip to content

Commit

Permalink
fix: [Dashboard > Entity Analytics: Risk Scores Table][KEYBOARD]: Ele…
Browse files Browse the repository at this point in the history
…ments with keyboard focus must be visible (elastic#178317)

Closes: elastic/security-team#8624

## Description

The Overview dashboard has two buttons that are invisible on keyboard
focus. These buttons toggle modal dialogs and are only visible on hover.
Screenshot attached.

### Steps to recreate

1. Open [Entity Analytics
dashboard](https://kibana.siem.estc.dev/app/security/entity_analytics)
2. Open dev tools and type `document.activeElement` into the live
expression window to have the active element follow your focus
3. Tab through the view until focus gets "lost" or disappears in the
User Risk Scores table rows
4. Verify focus is on a button that is not visible on the page

### Screen 


https://github.com/elastic/kibana/assets/20072247/0ca8db38-006a-49ea-9019-e23078844c10
  • Loading branch information
alexwizp authored Mar 12, 2024
1 parent 3401d3d commit 322b9a4
Showing 1 changed file with 5 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,18 @@ export const StyledBasicTable = styled(EuiBasicTable)`
}
}
.inlineActions {
.inlineActions button {
opacity: 0;
}
.EntityAnalyticsTableHoverActions {
.inlineActions-popoverOpen {
.inlineActions-popoverOpen button {
opacity: 1;
}
.inline-actions-table-cell:hover {
.inlineActions {
.inline-actions-table-cell {
.inlineActions button:focus-visible,
&:hover .inlineActions button {
opacity: 1;
}
}
Expand Down

0 comments on commit 322b9a4

Please sign in to comment.