All tracks are missing trackSpecialSettings

[Nokkasiili]

Example from Darwin - Two Snakes:S fttt12
Description of this string can be seen here:

playforia-minigolf/client/src/main/java/agolf/game/GameChatPanel.java

Line 116 in 85da3d2

this.textAreaChat.addMessage("Special settings:");

[PhilippvK]

Thanks for reporting!

Is this broken since #65 or was this never working in this repo?

[Nokkasiili]

Not sure but they are in old repo
https://github.com/WorldStarHipHopX/playforia/blob/7a7e573a1688bf62f465173153f4936b27430be5/tracks/modern/Darwin-_sgard.track#L5

[PhilippvK]

@pehala Any opinion?

[PhilippvK]

The S Row was not documented in https://github.com/PhilippvK/playforia-minigolf/blob/master/doc/FileFormat.md as far as I can tell.

[Nokkasiili]

#88

[Nokkasiili]

needs also be implemented here
https://github.com/PhilippvK/playforia-minigolf/blob/master/shared/src/main/java/org/moparforia/shared/tracks/Track.java

[pehala]

Thanks for the report. It indeed looks like it is missing from my new implementation as it wasn't properly documented, is it an optional row or a mandatory one?

As you correctly point out the S row need to be implemented in all kinds of different places, since Track will be changed.

@Nokkasiili Would you like to try to add that to your PR or should I edit it? Since tracks are now covered by tests you should get a good idea if the new implementation is correct from them and compile errors combined.

[Nokkasiili]

playforia-minigolf/client/src/main/java/agolf/game/GameBackgroundCanvas.java

Line 13 in 85da3d2

private static final String defaultTrackSettings = "fttt14";

Client will use default value if its missing