Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to bootstrap 4 and better meeting WCAG3 guidelines #109

Open
Pierre-Sassoulas opened this issue Nov 11, 2020 · 2 comments
Open

Upgrade to bootstrap 4 and better meeting WCAG3 guidelines #109

Pierre-Sassoulas opened this issue Nov 11, 2020 · 2 comments
Labels
enhancement This is a feature not a bug hacktoberfest

Comments

@Pierre-Sassoulas
Copy link
Owner

I would propose going a step further and creating a more accessible stylesheet than the current implementation. The grey backdrop doesn't meet the contrast ratio required for WCAG 3 accessibility guidelines - I know this is a minor suggestion, possibly due to use case (patient research)/HIPAA compliance background, but it can't hurt?

#108 (comment)

@d-horner
Copy link

@Pierre-Sassoulas would you be open to including third-party css/js libraries from a CDN like cdnjs's one vs serving it locally? Typically increases performance and decreases bandwidth vs serving the static files from within the project - with browsers caching the latest libraries for such popular frameworks/libs. Obviously, users of the project can override the base templates regardless.

@Pierre-Sassoulas
Copy link
Owner Author

I think it could become a setting option being opt-in, instead of the default, because the performance gain is not guaranteed and it could permit to inject malicious code. If creating the option is too much work, let's just make the override of the template easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is a feature not a bug hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants