-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix on Portuguese translation #188
Bugfix on Portuguese translation #188
Conversation
a726fc7
to
972a51f
Compare
looks like there is a problem with https://pypi.org/project/django-bootstrap-form/ and distutils, but it's not linked to my PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you. Do you want to fix the issue with setuptools due to python 3.12 in another MR first ? I won't be able to do that this week (I'm on mobile).
requirements.txt
Outdated
@@ -5,3 +5,4 @@ django-registration>=3.0 | |||
pytz>=2018.9 | |||
ordereddict>=1.1 | |||
pyyaml>=4.2b1 | |||
numpy<2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to add numpy ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's because numpy>=2 is breaking some dependencies (see https://stackoverflow.com/questions/78634235/numpy-dtype-size-changed-may-indicate-binary-incompatibility-expected-96-from )
I let you do that in the next weeks, there is no rush ! |
Hey, the main branch is fixed, sorry about the delay. |
Thanks @Pierre-Sassoulas ! |
We'd want to merge this one first, right ? |
c154be6
to
8945146
Compare
@Pierre-Sassoulas sorry, I read it wrong, now it should be ok ! |
362c18c
to
188551c
Compare
Seems like a recompile was necessary. I added some test so we check that it's recompiled properly too. Released in https://pypi.org/project/django-survey-and-report/1.4.8/ |
I had a trouble with Portuguese translation with Django 4.2 and python 3.9 :
So I updated the PO and MO, tell me if it's OK for you !