Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix on Portuguese translation #188

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

g-normand
Copy link

@g-normand g-normand commented Aug 7, 2024

I had a trouble with Portuguese translation with Django 4.2 and python 3.9 :

Capture d’écran de 2024-08-07 07-22-21

So I updated the PO and MO, tell me if it's OK for you !

@g-normand g-normand force-pushed the _bugfix_portuguese branch 3 times, most recently from a726fc7 to 972a51f Compare August 7, 2024 13:41
@g-normand
Copy link
Author

looks like there is a problem with https://pypi.org/project/django-bootstrap-form/ and distutils, but it's not linked to my PR

Copy link
Owner

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you. Do you want to fix the issue with setuptools due to python 3.12 in another MR first ? I won't be able to do that this week (I'm on mobile).

requirements.txt Outdated
@@ -5,3 +5,4 @@ django-registration>=3.0
pytz>=2018.9
ordereddict>=1.1
pyyaml>=4.2b1
numpy<2
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to add numpy ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@g-normand
Copy link
Author

LGTM, thank you. Do you want to fix the issue with setuptools due to python 3.12 in another MR first ? I won't be able to do that this week (I'm on mobile).

I let you do that in the next weeks, there is no rush !

@Pierre-Sassoulas
Copy link
Owner

Hey, the main branch is fixed, sorry about the delay.

@g-normand
Copy link
Author

Thanks @Pierre-Sassoulas !
Could you also update the version on pip?
It's still on 1.4.7 (https://pypi.org/project/django-survey-and-report/)

@Pierre-Sassoulas
Copy link
Owner

We'd want to merge this one first, right ?

@g-normand
Copy link
Author

@Pierre-Sassoulas sorry, I read it wrong, now it should be ok !

@Pierre-Sassoulas Pierre-Sassoulas merged commit 459ada7 into Pierre-Sassoulas:main Oct 31, 2024
6 checks passed
@Pierre-Sassoulas Pierre-Sassoulas added this to the 1.4.8 milestone Oct 31, 2024
@Pierre-Sassoulas
Copy link
Owner

Seems like a recompile was necessary. I added some test so we check that it's recompiled properly too. Released in https://pypi.org/project/django-survey-and-report/1.4.8/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants