Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Identity UserManager and RoleManager implementations for interacting with Users and Roles. #1641

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tedvanderveen
Copy link
Contributor

This allows for bringing your own implementations of those UserManager and RoleManager classes provided by ASP.Net Identity.

See also #1634

…re.Identity.EntityFrameworkCore

Use standard functionality of UserManager and RoleManager classes in UserController and RoleController (so remove dependency on IDB)
@tidyui
Copy link
Member

tidyui commented Jun 7, 2021

Sorry for the slow reply, but I've just been super busy! This looks very interesting indeed, we might have to schedule it for a service release of 9.1 but we'll definitely take a good look at it!

Regards

@tedvanderveen
Copy link
Contributor Author

Thanks for getting back. Been very busy myself as well. But scheduling to spend more time on this one next week. Please share you thoughts and feedback when you have a moment. So I can take it from there.

@lgtm-com
Copy link

lgtm-com bot commented Aug 11, 2021

This pull request fixes 1 alert when merging 174e9a9 into 7e5ac03 - view on LGTM.com

fixed alerts:

  • 1 for Dereferenced variable may be null

@tidyui
Copy link
Member

tidyui commented Aug 11, 2021

Could you put back the removed data package references to RazorWeb? We use this project as an entry point when generating migrations for the different data providers.

Best regards

Håkan

@tedvanderveen
Copy link
Contributor Author

Could you put back the removed data package references to RazorWeb? We use this project as an entry point when generating migrations for the different data providers.

Best regards

Håkan

Done. See 52d65a2

@tedvanderveen
Copy link
Contributor Author

@tidyui I'm planning to further test this PR next week. Is that okay timewise?

@lgtm-com
Copy link

lgtm-com bot commented Aug 12, 2021

This pull request fixes 1 alert when merging 52d65a2 into 9285f73 - view on LGTM.com

fixed alerts:

  • 1 for Dereferenced variable may be null

@tidyui
Copy link
Member

tidyui commented Oct 7, 2021

@tedvanderveen What's the status on this? Is it ready to be merged or should we postpone it for the next release?

@tidyui tidyui modified the milestones: Version 9.2, Version 10.0 Oct 7, 2021
@tedvanderveen
Copy link
Contributor Author

@tidyui I shall pick up on my tasks next week, should have plenty of time available to work on this!

@tidyui
Copy link
Member

tidyui commented Oct 23, 2021

We should probably get #1742 merged before doing any updates to this one.

@tidyui tidyui removed this from the Version 10.0 milestone Oct 27, 2021
@tidyui
Copy link
Member

tidyui commented Oct 27, 2021

Removed from project and milestone as issue #1634 is already added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants