Update glium and winit backends #1443
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Basically, this updates:
so that projects that use conrod + glium + winit can update as well.
No clever modification was needed. I created
backends/conrod_winit/src/v024.rsandbackends/conrod_winit/src/v025.rsfiles in order to be consistent, but these are just copies ofbackends/conrod_winit/src/v023.rs. It does not seem winit broke things related to events; as far as I can tell, these conversion macros work the same in winit 0.25 as they did in winit 0.23.In other projects
Theses changes were made in order to upgrade glium/winit in the MakAir Control UI project:
Also, I had to do the same on plotters-conrod, a dependency we use:
Everything seems to work fine, for what I have seen 😀