Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is Phinch limited to Chrome Browser? #57

Open
iimog opened this issue Apr 12, 2016 · 2 comments
Open

Why is Phinch limited to Chrome Browser? #57

iimog opened this issue Apr 12, 2016 · 2 comments

Comments

@iimog
Copy link
Contributor

iimog commented Apr 12, 2016

I wondered why Phinch is limited to Chrome Browser?
For testing I downloaded and installed Phinch locally.
After applying the fix in #49 and adding Firefox to the list of allowed userAgents I was able to visualize my biom files.
I found no obvious problems with Firefox in comparison to Chrome.
Are there specific things I can look at?
Otherwise the restriction to Chrome might be outdated and can be removed?

@hollybik
Copy link
Collaborator

We optimized Phinch for use with Google Chrome, and that is the browser we recommend for users accessing the public web implementation at http://phinch.org - but in reality the codebase is designed to work with all modern browsers. We haven't extensively tested across browsers yet (since there may be slight variations in the underlying javascript library paths), but glad to hear that you were able to find a fix for Firefox and get Phinch working!

@iimog
Copy link
Contributor Author

iimog commented Jun 13, 2016

Thanks for the explanation. For me this issue is resolved and can be closed.
Just a short note:
The Browser Support section in the wiki (https://github.com/PitchInteractiveInc/Phinch/wiki#browser-support) might be slightly misleading:

Phinch supports so-called “modern” browsers, which generally means everything except IE8 and below. D3 is tested against Firefox, Chrome (Chromium), Safari (WebKit), and Opera. Parts of Phinch may work in older browsers. You'll need a modern browser to use SVG and CSS3 Transitions.

While this is generally true, the current version of Phinch explicitly blocks all other browsers than Chrome.

@iimog iimog mentioned this issue Oct 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants