Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Captcha for registration form can be bypassed #4

Open
valbewe opened this issue Feb 18, 2023 · 3 comments
Open

Captcha for registration form can be bypassed #4

valbewe opened this issue Feb 18, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@valbewe
Copy link

valbewe commented Feb 18, 2023

** Prestashop Version **
8.0.1

** Cloudflare Turnstile Version **
1.1.1

** Do you use a specific theme **
Standard free theme that comes with the installation of Presta

Describe the bug
If I'm not logged in and add products to my shopping cart and then go to checkout, I can either order as a guest or log in. However, if guest ordering is disabled, then the page will show registration instead.
In this way, the captcha for registration can be bypassed.

A similar problem was described here: nenes25/eicaptcha#124

Would you like to fix this or can you give me a tip on how to implement the captcha at this point?

In any case, thank you for the great module!

@magentix magentix self-assigned this Feb 18, 2023
@magentix magentix added enhancement New feature or request good first issue Good for newcomers labels Feb 18, 2023
@magentix
Copy link
Collaborator

Hi @valbewe

This will be available in the next minor release (1.2.0)

The difficulty is that the register and login templates are on the same page and share the same controller (OrderController). This actually conflicts with the rendering of the widget on registration and login pages.

There will be a new mandatory parameter in the the widget call to identify the form:

{widget name='pixel_cloudflare_turnstile' form="register"}
{widget name='pixel_cloudflare_turnstile' form="login"}
{widget name='pixel_cloudflare_turnstile' form="contact"}
{widget name='pixel_cloudflare_turnstile' form="password"}

Regards,
Matthieu

@magentix
Copy link
Collaborator

magentix commented Apr 7, 2023

Hi,

Development is in progress, it will be available in 1.2.0.

@alapiere
Copy link

Hi ,
When the 1.2.0 will be avilable ? I'd really like to make turnstile work on ps reg form, and to distinguish login actions from register actions in turnstile stats; as we are under registration form spam attack ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants