name, rules addition and flavor addition

[ajakkes]

Looking at the rules book some things are considered part of the name of the card and some aren't.
Some are added to make rules clear and some are just for flavor.

I think it would be good to change this in the database.

So with Gengar and Gengar lv.43 the "lv.43" is just nameFlavor. It is not part of the name, you may not have 4 Gengars and Gengars lv.43. And it is no addition to the rules. This is the same for Delta Species.

But a Star behind the name is part of the name and as such should be part of the name in the database. Just like Alolan and Rocket's.

When things change the way rules work, like VMAX or Radiant. These values should go into the 'subtype'.

I propose a field called 'nameFlavor' to split these values from the name and 'subtypes'.

[Cealgair]

I personally think they're fine in "subtypes". There is pull request #509 which adds Delta Species as a subtype while removing the delta at the end of the names. There is already a field for the level. I don't think it's a good idea to remove the "LV. X" from the names, even though it's not part of the name as far as the rules are concerned.

[ajakkes]

It would make for a very simple check for deck legality and what Pokemon can evolve from what Pokemon.

It could also hold values like: "Goldenrod Game Corner", "Rocket's Secret Machine" which are now in the 'subtype' field. Where I think they don't belong.

And make it clear that Professor's Research (Professor Oak) is just a flavor difference from the normal Professor's Research. You still can't have more then four, and there is no rule that makes 'Professor Oak' a subtype.

It now feels like inconsistency. This is of course the result of Pokemon themself when stating "Symbols at the end of a Pokémon’s name are part of a Pokémon’s name" ... "However, δ (Delta Species) is not part of a Pokémon’s name. Aerodactyl and Aerodactyl δ (Delta Species) have the same name". They didn't think it trough.

[ajakkes]

See also #450

And #307 could be fixed this way as well.