-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I need to pass extra env variables when building. #8
Comments
no_proxy is deduced from the case when you don't have either one of the others, right ? :) a not-so-bad approach (cc @fbochu ?) would be using an environment file and pass it to builder.py somehow: ./builder.py --env-file=environment and the builder copies it to the machine if needed in the builder calls, or passes it to running compiler machine with the "docker run --env-file" native param. |
An other answer to this problem can be that the devs build the image and provide its hash. Then when you pull the image from your registry, you check the hash (this will serve as guarantee for non-alteration of the image). |
such synchro, much wow |
Amen. |
@rbarrois : They can do a hotfix by adding a new commit to the existing image. |
@fbochu yes, but then they need to build and deploy the image - without dev being around. |
@fbochu Agreed. I think that the build process should be done once. Registry v2 now create a SHA256 digest for images it stores. And since docker 1.6 we can pull images with a particular digest. https://docs.docker.com/reference/commandline/cli/#listing-image-digests |
Can be done by now:
|
Hi,
It turns out that when I run builder.py in production environment, I need to pass some extra env variables to the compiler container in the compile_packages phase, including (but not limited to) http_proxy , https_proxy, no_proxy.
It would be helpful to be able to do so easily.
Update : actually, those extra env vars are also needed in 'docker build' calls.
The text was updated successfully, but these errors were encountered: