Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

Add mixin for align-items:stretch #96

Open
lesliana opened this issue Jun 6, 2016 · 7 comments
Open

Add mixin for align-items:stretch #96

lesliana opened this issue Jun 6, 2016 · 7 comments

Comments

@lesliana
Copy link

lesliana commented Jun 6, 2016

There are mixins for all the other align-items values (flex-start, flex-end, center, baseline), but it doesn't look like there's a mixin for align-items:stretch yet.

@notwaldorf
Copy link
Contributor

align-items: stretch is the default, I believe, which is why it didn't get a separate mixin.

@zhaoz
Copy link
Contributor

zhaoz commented Jun 6, 2016

This would still be valuable to explicitly set even if it is default, right?

@lesliana
Copy link
Author

lesliana commented Jun 7, 2016

I realize I don't actually need a mixin for align-items:stretch where I
thought I did. There is still a chance it could still be useful for
elements that need to override another styling.

2016-06-06 16:50 GMT-07:00 zhaoz [email protected]:

This would still be valuable to explicitly set even if it is default,
right?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#96 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABGfmRR6KU2cJMV9syq_PfCAz4OXxI8vks5qJLJEgaJpZM4IvbKi
.

@timeu
Copy link

timeu commented Sep 1, 2016

align-items: stretch would be useful in a mobile first approach, where a media-queries would reset the cross-axis behavior to stretch:

/* for mobile a vertical setup centered along the cross-axis (horizontally)*/
.section {
  @apply(--layout-vertical);
  @apply(--layout-center);
}

@media (min-width: 960px) {
  .section {
    @apply(--layout-horizontal);
    @apply(--layout-around-justified);
    /* here we need to stretch */ 
  }
}

@notwaldorf
Copy link
Contributor

If anyone wants to send a PR for this, it would be greatly appreciated! 🙏

@caranicas
Copy link

Which is preferred, PRs against master branch, or the 2.0-preview ?

@notwaldorf
Copy link
Contributor

@caranicas against master, please.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants