Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tokio-io is deprecated #118

Open
xbjfk opened this issue Jul 30, 2024 · 1 comment
Open

tokio-io is deprecated #118

xbjfk opened this issue Jul 30, 2024 · 1 comment

Comments

@xbjfk
Copy link

xbjfk commented Jul 30, 2024

Hello,
I was beginning to fork xz2 as well, until I came across this crate, thanks for maintaining it!

According to its docs, it has been deprecated in favor of tokio::io.
I tried doing this and it made it seemed to be a non trivial migration, so it might be worth removing tokio entirely, like flate2-rs did: rust-lang/flate2-rs#292, as well as trifectatechfoundation/bzip2-rs#89 and alexcrichton#109.

It seems the recommended approach is the async-compression crate, which unfortunately uses xz2 still, but I have made a PR: Nullus157/async-compression#288.

Thanks!

@xbjfk xbjfk changed the title tokio-io is deprecated. tokio-io is deprecated Jul 30, 2024
@ChanTsune
Copy link

Hello @xbjfk !

Thank you for your message and suggestions. I will review the deprecation notice and consider the migration challenges.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants