Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use new date_new from product table #1003

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

use new date_new from product table #1003

wants to merge 2 commits into from

Conversation

matthieu-rolland
Copy link
Contributor

@matthieu-rolland matthieu-rolland commented Mar 27, 2024 •
edited
Loading

Questions Answers
Description? use new date_new from product table
Type? improvement
BC breaks? yes
Deprecations? no
Fixed ticket?
How to test? to be tested with: PrestaShop/PrestaShop#35645

BC Break:

  • This is compatible from PS 9 only, it should be for a major release of the module, maybe we should make a branch for a next major ?

Matthieu Rolland and others added 2 commits March 27, 2024 17:28
@matthieu-rolland matthieu-rolland marked this pull request as ready for review April 2, 2024 11:51
@matthieu-rolland matthieu-rolland changed the title use new date_new from product table - DO NOT MERGE use new date_new from product table Apr 2, 2024
@matthieu-rolland matthieu-rolland mentioned this pull request Apr 2, 2024
Open
jolelievre
jolelievre requested changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @matthieu-rolland

the changes are good, but the mi compatibility of the module must be increased, it now requires PrestaShop 9.0 minimum with this modification

@Hlavtox
Copy link
Contributor

Hlavtox commented Apr 2, 2024

Great opportunity to kill compatibility with anything pre 9.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolelievre jolelievre jolelievre requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
PR Dashboard
Status: Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthieu-rolland @Hlavtox @jolelievre