-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump min compatibility to PHP 7.2.5 and PS 1.7.7, module version to 4.0.0 #941
base: dev
Are you sure you want to change the base?
Bump min compatibility to PHP 7.2.5 and PS 1.7.7, module version to 4.0.0 #941
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still a few issues with phpstan
In fact, phpstan checks failed at |
5eb3096
to
d4887a3
Compare
problem is solved by dropping PHP 7.1 support, and jumping to PHP 7.2.5 minimum instead. |
ab8a0cb
to
9586cf9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@florine2623 I don't see that issue on both PS1.7.8.9 and PS 8.1.x with installation made by these 2 commands:
Maybe you need to apply BO > Clear (PS) cache and FO > Clear (browser) cache before testing again. |
@florine2623 Normal on 1.7.6, you can ignore it. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR, I tested it and it seems to works with the version bump as you can see :
Untitled_.Dec.4.2023.3_47.PM.webm
Currently I tried it on 1.7.7.8 and with php 7.2.34 ( yes, I didn't have 7.2.5)
And I've this message when I want to have your PR :
As you can see most of them need 7.3 and other need 7.4 that not really 7.2.5
Another screenshot with php v7.3.33 :
except that, all seems to works as expected with php v7.4 and more
Tested on 1.7.7.8/8.0.x/8.1.x/develop
Waiting for your feedback
I am not sure, but did you run composer install and not composer update? 🤔 |
02603cf
to
dbd3032
Compare
ec7fe85
to
4cb8254
Compare
This PR is waiting for other PRs with major functioning changes before Release 4.0.0
All code changes are pure format changes so there is no need to check modules functions.
The only concern is bumping
doctrine/collections
: from ^1.4 to ^1.8 that can affects src/Adapter/AbstractAdapter and MySQL, so a full functioning check for PS 1.7.7+ is still needed ;)