Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SearchProvider.php #977

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Update SearchProvider.php #977

wants to merge 1 commit into from

Conversation

Prestaworks
Copy link
Contributor

Questions Answers
Description? Change translation domain for making it possible to change values in BO with module translation.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#35237.
How to test? Follow instructions in Issue report

@Prestaworks
Update SearchProvider.php
5d35459 
Change translation domain for making it possible to change values in BO with module translation.
Hlavtox
Hlavtox reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@Hlavtox Hlavtox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you want to do this? We want to retain the same translations as in the core, no?
This will only result in having to translate these strings again.

@Prestaworks
Copy link
Contributor Author

Two of those strings does not exist in core so it's impossible to translate them. Maybe because Core translations does not pickup from modules folder? But generally it's better to keep translations for modules with the module. If not, it's just hard to find where the translation is supposed to happen.

Hlavtox
Hlavtox requested changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@Hlavtox Hlavtox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PrestaShop/PrestaShop#35237 (comment)

@ps-jarvis ps-jarvis added the waiting for author Waiting for author's feedback label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hlavtox Hlavtox Hlavtox requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
waiting for author Waiting for author's feedback
Projects
PR Dashboard
Status: Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Impossible to translate sorting labels from Facetedsearch module
3 participants
@Prestaworks @Hlavtox @ps-jarvis