Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/BEAMS3D fidasim #195

Merged
merged 17 commits into from
Sep 11, 2023
Merged

Bugfix/BEAMS3D fidasim #195

merged 17 commits into from
Sep 11, 2023

Conversation

kudav
Copy link
Collaborator

@kudav kudav commented Sep 7, 2023

This fixes and improves various things for the FIDASIM interface:

  • Profiles are now also written to the equilibrium
  • E-Field and Et is correctly calculated
  • the -fidasim2 flag (for native cylindrical distribution) also activates the normal interface
  • Energy bins are calculated for largest mass
  • MPI and bug fixes

@kudav kudav requested a review from lazersos September 7, 2023 13:52
@kudav kudav self-assigned this Sep 7, 2023
@kudav kudav added the enhancement New feature or request label Sep 7, 2023
lazersos
lazersos approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@lazersos lazersos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem OK. I need to run the benchmarks on this repo to verify. We should also think of adding a regression test to the benchmarks folder.

@lazersos lazersos merged commit 5c30188 into develop Sep 11, 2023
2 checks passed
@lazersos lazersos deleted the bugfix/BEAMS3D_FIDASIM branch September 11, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazersos lazersos lazersos approved these changes

Assignees

@kudav kudav

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kudav @lazersos