Error handling in passes

[pandurangpatil]

No description provided.

[khemrajrathore]

we should also add handling in functions like addAstParent

[pandurangpatil]

done

[khemrajrathore]

also add handling for method linkToSingle

[pandurangpatil]

done

[khemrajrathore]

@pandurangpatil

• Newly added logs like logger.warn(s"Error in TypeHierarchyPass", ex) should be error logs
• Ideally the methods like linkToSingle or addAstParent, should also have handling, as with the current approach completeness cannot be gauranteed

Haven't reviewed for completeness of the changes, as that will take more time to review. Have reviewed for correctness

[pandurangpatil]

@pandurangpatil

• Newly added logs like logger.warn(s"Error in TypeHierarchyPass", ex) should be error logs
• Ideally the methods like linkToSingle or addAstParent, should also have handling, as with the current approach completeness cannot be gauranteed

Haven't reviewed for completeness of the changes, as that will take more time to review. Have reviewed for correctness

I have made them warning to make sure it doesn't get bloated on the console. However, it will get logged into debug file.

[pandurangpatil]

@khemrajrathore for completeness. If there is any critical error being thrown in between. I am sure it will fail the scan in finding dataflow or somewhere else. Which will make sure to log the errors in warning as well as that will indirectly mean the respective scan failure will require proper fix for the failures in overlay passes.

[khemrajrathore]

LGTM