-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit tests #41
Comments
Read about Adding unit tests for C++ code for step-wise directions. |
Issue #74 is now closed |
All of the searching algorithms currently have unit tests, but they don't have a common unit test. However, there is a common test for sorting, which may be useful for implementing a common searching unit test. |
@faheel Regarding a common test for searching algorithms, is it your belief that this should include ternary search? The interface and use of ternary search differs from the other two existing search algorithms (linear and binary), which makes me wonder if it would be more straightforward to have a common test for binary and linear (and similar algorithms which may be added later) and then a separate test for ternary search. Not as clean as the sorting implementation I added earlier, but maybe a better fit for the objective at hand. |
@alxmjo Having a common unit test for linear and binary search and a separate one for ternary search would be best. |
Hey, I'd love to give this a crack. Let me know if the issue is still open for any left over algorithms. |
@safderareepattamannil If you're still interested, we're still missing a common test for searching algorithms. Have a look at the common test for sorting algorithms for an idea of how you might implement it. |
@alxmjo Hey, I am interested to give it a try ! |
Hello, |
@amrii1 Yes! See the post at the top of the thread. Currently still need a common test for linear and binary search, and then standalone test files for ternary search and radix sort. Please create a new issue if you have questions or would like to discuss implementation. 🙂 |
@Abdulwahab-Alobaid-2191115290 The unit tests for searching algorithms have already been added. You can pick up something else if you like. |
I'm planning to submit testing for the radix search within a week or two. |
What I have to do?? |
A fix for radix sort has been added in #420. Feel free to review the code and run the tests (and suggest new edge cases if any). |
Add unit tests for the following programs:
* Ternary search currently has a unit test but it needs to be refactored.
The text was updated successfully, but these errors were encountered: