Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the @phpstan-ignore annotation in the MailboxEmail factory #794

Open
marien-probesys opened this issue Nov 7, 2024 · 0 comments
Open
Labels
easy task Good for first time contributors external blocking Just waiting for some external actions technical debt The past will not stop us from moving forward type: technical These are of interest to administrators
Milestone

Comments

@marien-probesys
Copy link
Member

marien-probesys commented Nov 7, 2024

Problem

Foundry 2.2.2 doesn't correctly type the instantiator parameter of instantiateWith. See zenstruck/foundry#721.
As this is not an important issue, I preferred to update Foundry and add the annotation to ignore the issue.

Solution

Update Foundry and remove the annotation and the related comment in \App\Tests\Factory\MailboxEmailFactory.

@marien-probesys marien-probesys added easy task Good for first time contributors type: technical These are of interest to administrators technical debt The past will not stop us from moving forward external blocking Just waiting for some external actions labels Nov 7, 2024
@marien-probesys marien-probesys added this to the Version 0.13-beta milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy task Good for first time contributors external blocking Just waiting for some external actions technical debt The past will not stop us from moving forward type: technical These are of interest to administrators
Projects
None yet
Development

No branches or pull requests

1 participant