From 03027f78514fe65de6c7e8fa5e9a5adab424990c Mon Sep 17 00:00:00 2001
From: Marien Fressinaud <marien.fressinaud@probesys.coop>
Date: Mon, 21 Oct 2024 11:49:24 +0200
Subject: [PATCH] fix: Fix LDAP sync when creating new users

---
 src/Repository/AuthorizationRepository.php    |  4 ++
 .../SynchronizeLdapHandlerTest.php            | 48 +++++++++++++++----
 2 files changed, 44 insertions(+), 8 deletions(-)

diff --git a/src/Repository/AuthorizationRepository.php b/src/Repository/AuthorizationRepository.php
index af28964b..7f3c642c 100644
--- a/src/Repository/AuthorizationRepository.php
+++ b/src/Repository/AuthorizationRepository.php
@@ -100,6 +100,10 @@ public function getOrgaAuthorizationsFor(User $user, mixed $scope): array
      */
     public function loadUserAuthorizations(User $user): array
     {
+        if ($user->getId() === null) {
+            return [];
+        }
+
         $keyCache = $user->getUid();
 
         if (!isset($this->cacheAuthorizations[$keyCache])) {
diff --git a/tests/MessageHandler/SynchronizeLdapHandlerTest.php b/tests/MessageHandler/SynchronizeLdapHandlerTest.php
index 6bcef0bd..5b196bfb 100644
--- a/tests/MessageHandler/SynchronizeLdapHandlerTest.php
+++ b/tests/MessageHandler/SynchronizeLdapHandlerTest.php
@@ -6,8 +6,8 @@
 
 namespace App\Tests\MessageHandler;
 
-use App\Message\SynchronizeLdap;
-use App\Tests\Factory\UserFactory;
+use App\Message;
+use App\Tests\Factory;
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
 use Symfony\Component\Messenger\MessageBusInterface;
 use Zenstruck\Foundry\Test\Factories;
@@ -24,13 +24,13 @@ public function testInvokeCreatesUsers(): void
         /** @var MessageBusInterface */
         $bus = $container->get(MessageBusInterface::class);
 
-        $this->assertSame(0, UserFactory::count());
+        $this->assertSame(0, Factory\UserFactory::count());
 
-        $bus->dispatch(new SynchronizeLdap());
+        $bus->dispatch(new Message\SynchronizeLdap());
 
-        $this->assertSame(2, UserFactory::count());
+        $this->assertSame(2, Factory\UserFactory::count());
 
-        $users = UserFactory::all();
+        $users = Factory\UserFactory::all();
         $this->assertSame('charlie', $users[0]->getLdapIdentifier());
         $this->assertSame('charlie@example.com', $users[0]->getEmail());
         $this->assertSame('Charlie Gature', $users[0]->getName());
@@ -44,17 +44,49 @@ public function testInvokeUpdateUsers(): void
         $container = static::getContainer();
         /** @var MessageBusInterface */
         $bus = $container->get(MessageBusInterface::class);
-        $user = UserFactory::createOne([
+        $user = Factory\UserFactory::createOne([
             'email' => 'cgature@example.com',
             'name' => 'C. Gature',
             'ldapIdentifier' => 'charlie',
         ]);
 
-        $bus->dispatch(new SynchronizeLdap());
+        $bus->dispatch(new Message\SynchronizeLdap());
 
         $user->_refresh();
         $this->assertSame('charlie@example.com', $user->getEmail());
         $this->assertSame('Charlie Gature', $user->getName());
         $this->assertSame('charlie', $user->getLdapIdentifier());
     }
+
+    public function testInvokeCanSetDefaultAuthorizations(): void
+    {
+        $container = static::getContainer();
+        /** @var MessageBusInterface */
+        $bus = $container->get(MessageBusInterface::class);
+        $defaultRole = Factory\RoleFactory::createOne([
+            'type' => 'user',
+            'isDefault' => true,
+        ]);
+        $defaultOrganization = Factory\OrganizationFactory::createOne([
+            'domains' => ['example.com'], // don't include example.org
+        ]);
+
+        $bus->dispatch(new Message\SynchronizeLdap());
+
+        $this->assertSame(2, Factory\UserFactory::count());
+        $this->assertSame(1, Factory\AuthorizationFactory::count());
+
+        $users = Factory\UserFactory::all();
+        $this->assertSame('charlie@example.com', $users[0]->getEmail());
+        Factory\AuthorizationFactory::assert()->exists([
+            'holder' => $users[0],
+            'role' => $defaultRole,
+            'organization' => $defaultOrganization,
+        ]);
+        $this->assertSame('dominique@example.org', $users[1]->getEmail());
+        // example.org is not handled by any organization
+        Factory\AuthorizationFactory::assert()->notExists([
+            'holder' => $users[1],
+        ]);
+    }
 }