Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom year validation messages #87

Open
malberts opened this issue Nov 22, 2022 · 1 comment
Open

Add custom year validation messages #87

malberts opened this issue Nov 22, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@malberts
Copy link
Collaborator

malberts commented Nov 22, 2022

From #79 (comment) and #55

@malberts malberts added the enhancement New feature or request label Nov 22, 2022
@malberts
Copy link
Collaborator Author

I started looking at this, but there seems to be different behavior between Firefox and Brave.

Branch: https://github.com/ProfessionalWiki/WikibaseExport/compare/year-error?expand=1

It's possible to change the validation message and it's also possible to trigger the validation message as the user types. The current state of the branch has an issue where the validation message doesn't auto-close in Firefox and it also looks like it's not updating to the correct error when you go from an invalid value to another invalid one, or if you go from an invalid one to a valid one. The moment you click away and back, or leave the invalid value and submit, then the correct one shows up.

I'll come back to this once other more important tasks are done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant