Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve JavaScript #77

Open
malberts opened this issue Aug 9, 2022 · 1 comment
Open

Improve JavaScript #77

malberts opened this issue Aug 9, 2022 · 1 comment

Comments

@malberts
Copy link
Contributor

malberts commented Aug 9, 2022

Blocks #67

Current JS CS review:

npm run grunt

Screenshot_20220809_224007

The errors will cause CI failure, so this needs to be fixed first.

Also look at #76 (comment)
This was referenced Nov 14, 2022
Merged
Merged
@malberts
Copy link
Contributor Author

ESLint warning level for "no-jquery/no-class-state" must be removed as part of this task. The warning was added in #118 to make the current code at least pass CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@malberts