Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container to fluid #23

Open
danielmrey opened this issue Feb 20, 2018 · 2 comments
Open

Container to fluid #23

danielmrey opened this issue Feb 20, 2018 · 2 comments

Comments

@danielmrey
Copy link
Contributor

Hi Simon:

I will do this in my final child but you may want to add it to the master, as behaviour is better, I think is something similar of what you wanted to achieve with your container-responsive, but without adding any new class. Instead of jumps all adapts beautifully, is also better for small devices as you do not have such a big white space left and right:

  • Change 3 classes:
    class="container" to class="container-fluid"

  • Add this rule:
    .container-fluid {max-width: 1140px !important;}

Thanks

@SimonPadbury
Copy link
Member

That was essentially my .container-responsive but you wanted me to delete it.

@danielmrey
Copy link
Contributor Author

I don't think I told you to remove it:

  • I think what I said was to have all new classes with "progenitor-" before the class name, so I suggested ".progenitor-container-responsive"

  • But at some point you said: "I am also going to delete .container-responsive entirely."

  • And I said: "I also think you are right in removing "container-responsive"... if you replace with just "container" would render ok..."

  • And now I think is a good idea to do apply new idea, as all will be elastic with no whites right or left in some breakpoint scenarios, but you decide:

Change 3 classes: class="container" to class="container-fluid"
Add this rule: .container-fluid {max-width: 1140px !important;}

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants